Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding autocnet #27978

Merged
merged 27 commits into from
Oct 30, 2024
Merged

Adding autocnet #27978

merged 27 commits into from
Oct 30, 2024

Conversation

amystamile-usgs
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/autocnet/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: Kelvinrr. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Oct 23, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/autocnet/meta.yaml) and found some lint.

Here's what I've got...

For recipes/autocnet/meta.yaml:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@Kelvinrr
Copy link
Contributor

I consent to be a maintainer for this recipe

Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/autocnet/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/autocnet/meta.yaml) and found some lint.

Here's what I've got...

For recipes/autocnet/meta.yaml:

  • The top level meta key channels is unexpected

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/autocnet/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/autocnet/meta.yaml) and found some lint.

Here's what I've got...

For recipes/autocnet/meta.yaml:

  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/autocnet/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipes/autocnet/meta.yaml:

  • No valid build backend found for Python recipe for package autocnet using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/autocnet/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Oct 24, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/autocnet/meta.yaml) and found some lint.

Here's what I've got...

For recipes/autocnet/meta.yaml:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/autocnet/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/autocnet/meta.yaml) and found some lint.

Here's what I've got...

For recipes/autocnet/meta.yaml:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/autocnet/meta.yaml) and found it was in an excellent condition.

@amystamile-usgs
Copy link
Contributor Author

@conda-forge/help-python Not sure why the mac build is hanging.

recipes/autocnet/meta.yaml Outdated Show resolved Hide resolved
recipes/autocnet/meta.yaml Outdated Show resolved Hide resolved
recipes/autocnet/meta.yaml Outdated Show resolved Hide resolved
recipes/autocnet/meta.yaml Outdated Show resolved Hide resolved
recipes/autocnet/meta.yaml Outdated Show resolved Hide resolved
@ocefpaf
Copy link
Member

ocefpaf commented Oct 30, 2024

Not sure why Windows is hanging but b/c this is noarch we can merge it.

@ocefpaf ocefpaf merged commit 8e9feb3 into conda-forge:main Oct 30, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants