-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bioconda perl migration round 2 (noarch) #25306
base: main
Are you sure you want to change the base?
bioconda perl migration round 2 (noarch) #25306
Conversation
Hi! Thanks for your contribution to conda-forge. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/perl-archive-extract:
For recipes/perl-archive-extract:
For recipes/perl-class-accessor:
For recipes/perl-class-accessor:
For recipes/perl-config-general:
For recipes/perl-config-general:
For recipes/perl-html-tagset:
For recipes/perl-html-tagset:
For recipes/perl-math-vecstat:
For recipes/perl-math-vecstat:
For recipes/perl-parse-recdescent:
For recipes/perl-parse-recdescent:
For recipes/perl-path-class:
For recipes/perl-path-class:
For recipes/perl-pod-parser:
For recipes/perl-pod-parser:
For recipes/perl-test-pod:
For recipes/perl-test-pod:
For recipes/perl-timedate:
For recipes/perl-timedate:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/perl-archive-extract:
For recipes/perl-class-accessor:
For recipes/perl-config-general:
For recipes/perl-html-tagset:
For recipes/perl-math-vecstat:
For recipes/perl-parse-recdescent:
For recipes/perl-path-class:
For recipes/perl-pod-parser:
For recipes/perl-test-pod:
For recipes/perl-timedate:
|
@conda-forge-admin, please ping conda-forge/staged-recipes Ready for review; Windows build is currently known to fail for |
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/staged-recipes and so here I am doing that. |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
Is @conda-forge/perl-packagers active? If so, then
|
Thanks...I thought previously to ping @conda-forge/help-perl but it looks like that team is empty. |
Hey guys, awesome work! Yes, please add perl-packagers as maintainers to your recipe. I hope I will have some time to review your contribution in the coming week. Unfortunately I cannot merge the PR myself, but once the recipes loon good, we can contact someone who can. At a first glance, I noticed you added lots of license files. That's not necessary for the default licenses, please look how we handled the matter e.g. here: https://github.com/conda-forge/perl-moose-feedstock/blob/main/recipe%2Fmeta.yaml Could you adopt your PR, please? Thank you so much! I'm looking foward to review this! |
@xileF1337 thanks for responding! Feel free to ping me when ready to merge. BTW, you may want to look over #25110. Since @jvolkening is transferring 450+ recipes, it would probably be helpful to post comments that general apply to Perl recipes there. |
@xileF1337 Many thanks for the feedback, I'll add conda-forge/perl-packagers as maintainers to everything I'm pushing. Re:
pod2text lib/perl5/core_perl/pod/perlartistic.pod > LICENSE.ARTISTIC
pod2text lib/perl5/core_perl/pod/perlgpl.pod > LICENSE.GPL Also, although these recipes are being auto-generated, I could also add some code to try harder to identify the actual license file (if present) in the CPAN packages to refer to that. Currently it was just easier to parse the license token from the API, validate against SPDX, and use |
@xileF1337 If and when time allows, would you also be willing to comment on #25312 ? It attempts to address some issues specific to Windows compilation that I ran into for platform-specific packages. |
RE: It's too bad this (auto license download) isn't a feature of conda-build for valid SPDX identifiers. Even allowing URLs in {% set license = "Artistic-1.0-Perl AND MIT" %}
{% set lic_list = license.replace( ' AND ', ' OR ' ).split( ' OR ' ) %} script:
- >-
perl Makefile.PL INSTALLDIRS=vendor NO_PERLLOCAL=1 NO_PACKLIST=1 MAKE=make
&& make
&& make test
&& make install VERBINST=1
{% for l in lic_list %}
- curl -o LICENSE.{{ l }}.txt https://spdx.org/licenses/{{ l }}.txt
{% endfor %} about:
license: {{ license }}
license_file:
{% for l in lic_list %}
- LICENSE.{{ l }}.txt
{% endfor %} |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/perl-archive-extract:
For recipes/perl-archive-extract:
For recipes/perl-class-accessor:
For recipes/perl-class-accessor:
For recipes/perl-config-general:
For recipes/perl-config-general:
For recipes/perl-html-tagset:
For recipes/perl-html-tagset:
For recipes/perl-math-vecstat:
For recipes/perl-math-vecstat:
For recipes/perl-parse-recdescent:
For recipes/perl-parse-recdescent:
For recipes/perl-path-class:
For recipes/perl-path-class:
For recipes/perl-pod-parser:
For recipes/perl-pod-parser:
For recipes/perl-test-pod:
For recipes/perl-test-pod:
For recipes/perl-timedate:
For recipes/perl-timedate:
|
Another batch of recipes migrated from bioconda, all
noarch: generic
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).