-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe for Perl module Encode #20570
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/perl-encode:
|
@conda-forge/bioconda-recipes Porting this to Conda Forge, any objections? |
@conda-forge/help-perl, ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; I've added a dew comments/suggestions. I started migrating Perl recipes from Bioconda to conda-forge a short while ago, so feel free to tag me in case you submit more Perl recipes.
|
||
extra: | ||
recipe-maintainers: | ||
- xileF1337 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to add me as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do. If you wish I can also add you to future recipe submissions.
recipes/perl-encode/build.sh
Outdated
perl ./Build install --installdirs site | ||
elif [ -f Makefile.PL ]; then | ||
# Make sure this goes in site | ||
perl Makefile.PL INSTALLDIRS=site |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure about this. The proposed conda-forge Perl documentation at conda-forge/conda-forge.github.io#1790 suggests INSTALLDIRS=vendor
, and that's what I've been using for all recipes I've migrated. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I don't know Conda well enough to judge which paths are most appropriate. If you consider vendor
to be the better option, I will use that. I took these files unchanged from the conda skeleton cpan
output.
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but couldn't find any. |
Is it normal for the linter to fail on subsequent commits ... ?! |
@cbrueffer I incorporated your suggestions, could approve pls? Thanks! |
I just realized this is for Encode 3.02, which is quite old. The current version is 3.19. Is that on purpose? |
The version was selected by |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/perl-encode:
|
@cbrueffer here we go, recipe updated to Encode 3.19. |
This is a recipe for the Perl module Encode.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).