Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe for Perl module Encode #20570

Merged
merged 8 commits into from
Sep 28, 2022
Merged

Conversation

xileF1337
Copy link
Contributor

@xileF1337 xileF1337 commented Sep 27, 2022

This is a recipe for the Perl module Encode.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/perl-encode) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/perl-encode:

  • Recipe with the same name exists in bioconda: please discuss with @conda-forge/bioconda-recipes.

@xileF1337
Copy link
Contributor Author

@conda-forge/bioconda-recipes Porting this to Conda Forge, any objections?

@xileF1337
Copy link
Contributor Author

@conda-forge/help-perl, ready for review!

Copy link
Member

@cbrueffer cbrueffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; I've added a dew comments/suggestions. I started migrating Perl recipes from Bioconda to conda-forge a short while ago, so feel free to tag me in case you submit more Perl recipes.

recipes/perl-encode/gpl-1.0.txt Outdated Show resolved Hide resolved
recipes/perl-encode/meta.yaml Outdated Show resolved Hide resolved
recipes/perl-encode/meta.yaml Outdated Show resolved Hide resolved
recipes/perl-encode/meta.yaml Outdated Show resolved Hide resolved

extra:
recipe-maintainers:
- xileF1337
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to add me as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. If you wish I can also add you to future recipe submissions.

perl ./Build install --installdirs site
elif [ -f Makefile.PL ]; then
# Make sure this goes in site
perl Makefile.PL INSTALLDIRS=site
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about this. The proposed conda-forge Perl documentation at conda-forge/conda-forge.github.io#1790 suggests INSTALLDIRS=vendor, and that's what I've been using for all recipes I've migrated. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I don't know Conda well enough to judge which paths are most appropriate. If you consider vendor to be the better option, I will use that. I took these files unchanged from the conda skeleton cpan output.

recipes/perl-encode/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@xileF1337
Copy link
Contributor Author

Is it normal for the linter to fail on subsequent commits ... ?!

@xileF1337
Copy link
Contributor Author

@cbrueffer I incorporated your suggestions, could approve pls? Thanks!

@cbrueffer
Copy link
Member

I just realized this is for Encode 3.02, which is quite old. The current version is 3.19. Is that on purpose?

@xileF1337
Copy link
Contributor Author

?

The version was selected by conda skeleton, I don't know what's the logic behind its algorithm. I thought there may be a reason and decided to leave it, but I can update it if that's a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/perl-encode) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/perl-encode:

  • Recipe with the same name exists in bioconda: please discuss with @conda-forge/bioconda-recipes.

@xileF1337
Copy link
Contributor Author

@cbrueffer here we go, recipe updated to Encode 3.19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants