-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround broken cmake config file #103
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
90fc510
to
ce5a000
Compare
@jschueller @xylar Sorry for being late to the party. Not sure if this helps, but it seems the issue will be solved netcdf-c, see Unidata/netcdf-c@023d3e9. Asking @WardF if this will fix the issue? |
yes, dont merge anything yet, i'll try to backport in another pr |
@jschueller, it might be worth adding yourself as a maintainer. |
That branch will fix it, but not as it currently stands. HDF5 logic is tricky, and I need to port over some additional work from the netcdf-c/CMakeLists.txt file :). |
@WardF Thanks for the update, much appreciated! |
I propose to merge this PR untils the fix lands in a netcdf to let wardf time to investigate. |
I'm going to give folks the rest of today to comment one way or the other and then I'll merge. |
try to work around Unidata/netcdf-c#1444
we manually pass hdf5 variables to avoid the find_package path which results in target names being added to cmake target config files instead of actual library paths.