Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround broken cmake config file #103

Merged
merged 1 commit into from
May 1, 2020
Merged

Conversation

jschueller
Copy link
Contributor

@jschueller jschueller commented Apr 24, 2020

try to work around Unidata/netcdf-c#1444
we manually pass hdf5 variables to avoid the find_package path which results in target names being added to cmake target config files instead of actual library paths.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@kmuehlbauer
Copy link
Contributor

@jschueller @xylar Sorry for being late to the party. Not sure if this helps, but it seems the issue will be solved netcdf-c, see Unidata/netcdf-c@023d3e9.

Asking @WardF if this will fix the issue?

@jschueller
Copy link
Contributor Author

yes, dont merge anything yet, i'll try to backport in another pr

@jschueller jschueller changed the title Workaround broken cmake config file [DONT MERGE] Workaround broken cmake config file Apr 29, 2020
@xylar
Copy link
Contributor

xylar commented Apr 29, 2020

@jschueller, it might be worth adding yourself as a maintainer.

@WardF
Copy link
Contributor

WardF commented Apr 29, 2020

@jschueller @xylar Sorry for being late to the party. Not sure if this helps, but it seems the issue will be solved netcdf-c, see Unidata/netcdf-c@023d3e9.

Asking @WardF if this will fix the issue?

That branch will fix it, but not as it currently stands. HDF5 logic is tricky, and I need to port over some additional work from the netcdf-c/CMakeLists.txt file :).

@kmuehlbauer
Copy link
Contributor

@jschueller @xylar Sorry for being late to the party. Not sure if this helps, but it seems the issue will be solved netcdf-c, see Unidata/netcdf-c@023d3e9.
Asking @WardF if this will fix the issue?

That branch will fix it, but not as it currently stands. HDF5 logic is tricky, and I need to port over some additional work from the netcdf-c/CMakeLists.txt file :).

@WardF Thanks for the update, much appreciated!

@jschueller jschueller changed the title [DONT MERGE] Workaround broken cmake config file Workaround broken cmake config file Apr 30, 2020
@jschueller
Copy link
Contributor Author

I propose to merge this PR untils the fix lands in a netcdf to let wardf time to investigate.

@xylar
Copy link
Contributor

xylar commented May 1, 2020

I'm going to give folks the rest of today to comment one way or the other and then I'll merge.

@xylar xylar merged commit a01e3c6 into conda-forge:master May 1, 2020
@jschueller jschueller deleted the hdf5 branch May 2, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants