-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add glib to host deps to build gts stuff + add ffmpeg #14
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…da-forge-pinning 2020.11.04.10.36.34
Something else that I noticed is missing is ffmpeg, but probably that is not strictly necessary for gazebo. |
Thanks for the hint - I added it and it seems to work 👍 |
Fix #15 |
@seanyen - all green, this is ready to be merged |
Add direct dependency on ignition-cmake2 cc @traversaro
The regression fixed by this PR was catched also by my nightly CI in https://github.com/robotology/robotology-superbuild/runs/1356099458 :
It would be nice to have some option in ignition-cmake upstream to have a clear error if the dependency of some components are missing instead of silently disabling the component, see gazebosim/gz-cmake#63 . |
Here we also have the chance to test whether the library was created - feel free to add these tests @traversaro |
Good point! I will open an issue to not forget about it. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)