-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable building Python bindings on Windows #19
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi @traversaro - sorry to bother you. We are running out of heap space here. I already set |
I never faced a problem like this. I see that Zm is related to precompile headers, if that does not work we could look into disabling pre-compiled headers? |
I think I misread the doc in https://learn.microsoft.com/en-us/cpp/error-messages/compiler-errors-1/fatal-error-c1060?view=msvc-170 - the /Zm flag is only helpful if there are also errors C1076 and C3859 which we don't have here. I am not sure about precompiled headers - it's using pybind11 for the Python bindings. Not sure what to do next, we could try if it builds locally on a more powerful machine? |
@sadsimulation - if you’re interested in this, could you try building locally and see if you are running into issues? |
Hi I'd love to try this out but I'm not sure where to start. Is it as simple as cloning the repo and running |
Yes, clone this repo/PR, then |
Thanks for the quick reply, is there a specific VisualStudio version required? I see references to VS2019 but VS2022 seems to be available. |
Okay this time I did not run out of memory at the same place, however peak memory usage was 6GB, not sure what the azure pipeline provides.. It does however now fail due to undefined references when linking the
Full build log below.
|
Probably a missing
and other classes or functions for which a linker error is printed. Some of those are missing in 4.2.0 and presented in the latest devel (see borglab/gtsam#1630), while some of them are also missing in devel. We could fix this by adding a patch to the recipe. |
I've started looking into this, just to clarify, the Is there a way to cache the build output or at least the environment? As this turns out to be an iterative process I spent a lot of time recompiling the same files over and over. |
With the latest patch
Which as previously stated should be fixed by adding @traversaro I'm not too familiar with C++ and the |
Just add an include should fix this :) #include <gtsam/dllexport.h> |
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin please rerender |
…nda-forge-pinning 2023.10.27.16.51.55
New error when trying vs2022:
Any ideas @traversaro? |
Has been reported in borglab/gtsam#1642. With the patches added in 872a724 the build successfully completes with VS2019.
Any plans to bump the CI pipelines available memory to > 6.4G? |
@conda-forge-admin please rerender |
…nda-forge-pinning 2023.10.28.08.31.46
@conda-forge-admin please rerender |
…nda-forge-pinning 2023.10.28.08.31.46
Sorry, I was away from keyboard! Anyhow, the |
That’s an interesting one:
|
I think it's because these pyd files aren't being installed:
|
This is ready for review @traversaro |
Thanks for the work! |
Thanks @sadsimulation |
Try to debug why gtsam Python bindings don't build as mentioned in #10.