Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exclude some build backends from python build backend lint/hint #2046

Merged
merged 6 commits into from
Sep 1, 2024
Merged

fix: exclude some build backends from python build backend lint/hint #2046

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aa35321
fix: exclude pdm-backend from pip build backend lint
beckermr Aug 30, 2024
6522b2e
Create 2046-pip-hint-exclude.rst
beckermr Aug 30, 2024
d42577c
Update conda_smithy/linter/hints.py
beckermr Aug 30, 2024
9da9535
Update conda_smithy/linter/hints.py
beckermr Aug 30, 2024
e0d738e
Update 2046-pip-hint-exclude.rst
beckermr Aug 30, 2024
9a915c8
Merge branch 'main' into beckermr-patch-1
beckermr Sep 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions conda_smithy/linter/hints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,9 @@ def hint_check_spdx(about_section, hints):


def hint_pip_no_build_backend(host_or_build_section, package_name, hints):
if package_name in ["pdm-backend", "setuptools"]:
beckermr marked this conversation as resolved.
Show resolved Hide resolved
return

if host_or_build_section and any(
req.split(" ")[0] == "pip" for req in host_or_build_section
):
Expand Down
23 changes: 23 additions & 0 deletions news/2046-pip-hint-exclude.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
**Added:**

* <news item>

**Changed:**

* <news item>

**Deprecated:**

* <news item>

**Removed:**

* <news item>

**Fixed:**

* Fixed error where ``pdm-backend`` was flagged as not having a backend. (#2046)

**Security:**

* <news item>
Loading