Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude some build backends from python build backend lint/hint #2046

Merged
merged 6 commits into from
Sep 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions conda_smithy/linter/hints.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,13 @@ def hint_check_spdx(about_section, hints):


def hint_pip_no_build_backend(host_or_build_section, package_name, hints):
# we do NOT exclude all build backends since some of them
# need another backend to bootstrap
# the list below are the ones that self-bootstrap without
# another build backend
if package_name in ["pdm-backend", "setuptools"]:
beckermr marked this conversation as resolved.
Show resolved Hide resolved
return

if host_or_build_section and any(
req.split(" ")[0] == "pip" for req in host_or_build_section
):
Expand Down
23 changes: 23 additions & 0 deletions news/2046-pip-hint-exclude.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
**Added:**

* <news item>

**Changed:**

* <news item>

**Deprecated:**

* <news item>

**Removed:**

* <news item>

**Fixed:**

* Fixed error where some python build backends were flagged as not having a backend. (#2046)

**Security:**

* <news item>
Loading