Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install conda_oci_mirror to use in conda-forge-ci-setup-feedstock #1683

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Hind-M
Copy link
Member

@Hind-M Hind-M commented Oct 26, 2022

Related to this conda-forge-ci-setup-feedstock PR

@Hind-M
Copy link
Member Author

Hind-M commented Nov 3, 2022

Hi folks,
This PR is meant to eventually add packages upload to GHCR in conda-forge (in parallel to anaconda.org). It is related to this PR in conda-forge-ci-setup-feedstock.
To make the upload happen, a Github token with the rights to upload packages in conda-forge must be used. How can it be generated (I guess only a code owner/maintainer can do that) and then added/propagated to all feedstocks?
Happy to discuss this further! Thanks.

@Hind-M Hind-M marked this pull request as ready for review November 3, 2022 14:21
@JohanMabille
Copy link

cc @ocefpaf

@wolfv
Copy link
Member

wolfv commented Nov 10, 2022

I think this is clearly not ready.

First, it shoudl probably go behind a feature flag enabled by conda-forge.yml file (check how the {{ BOA }} thing works.

And then, this isn't even doing anything at this point. You could fork a feedstock somewhere in your own private repository, and then run the new conda-smithy version there to try and actually upload any packages to an OCI registry. In your fork of the feedstock, you should be able to set tokens manually. When we want to later to this via Github Actions or Azure, we probably need to set additional secrets (apparently possible via the conda-forge.yml config file (or another config file, not sure on the details). I found some code in configure_feedstock.py which reads additional secrets from the config.

@wolfv
Copy link
Member

wolfv commented Nov 10, 2022

OK, I think I missed the bits in the conda-forge-ci-setup feedstock a bit. It would probably be better to instead add conda_oci_mirror as a package to conda-forge, and add it in the run requirements of the conda-forge-ci-setup package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants