Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an onerror handler to shutil.rmtree calls in tick_my_feedstocks.py #523

Merged
merged 1 commit into from
Feb 9, 2018

Conversation

tkelman
Copy link
Member

@tkelman tkelman commented Feb 8, 2018

Should avoid errors such as
PermissionError: [WinError 5] Access is denied: 'C:\\Users\\akelman\\AppData\\Local\\Temp\\tmpu3fwwzf4\\botocore-feedstock\\.git\\objects\\pack\\pack-75b2092341bff03adcd15b32b752762b5801440f.idx'

Should avoid errors such as
`PermissionError: [WinError 5] Access is denied: 'C:\\Users\\akelman\\AppData\\Local\\Temp\\tmpu3fwwzf4\\botocore-feedstock\\.git\\objects\\pack\\pack-75b2092341bff03adcd15b32b752762b5801440f.idx'`
@tkelman
Copy link
Member Author

tkelman commented Feb 8, 2018

I'd also kind of like to move the conda_smithy imports inside the regenerate_fork function so it's an optional dependency that you can avoid if you use --no-regenerate, but let me know if anyone has any preference for doing that in this PR or a separate one.

@isuruf isuruf requested a review from pmlandwehr February 8, 2018 21:13
@pmlandwehr
Copy link
Contributor

Thanks for this - might also want to check how it squares with the develop branch of the other tick-my-feedstocks I should really seem about merging those changes back into here at some point...

@tkelman
Copy link
Member Author

tkelman commented Feb 9, 2018

Right, saw that, opened pmlandwehr/tick-my-feedstocks#19 with basically the same change.

For another couple-line but only partially related change, would you prefer it to be added to these existing PR's or done separately?

@isuruf isuruf merged commit 6142dc2 into conda-forge:master Feb 9, 2018
@tkelman tkelman deleted the tk/rmtree-onerror branch February 9, 2018 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants