-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions about splitting header and runtime + run_export> packages #2257
Open
hmaarrfk
wants to merge
7
commits into
conda-forge:main
Choose a base branch
from
hmaarrfk:split_header_runtime
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
10 tasks
jaimergp
reviewed
Aug 9, 2024
Co-authored-by: jaimergp <[email protected]>
xhochy
reviewed
Aug 9, 2024
Co-authored-by: Uwe L. Korn <[email protected]>
Co-authored-by: Uwe L. Korn <[email protected]>
xhochy
approved these changes
Aug 12, 2024
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
jaimergp
reviewed
Aug 15, 2024
jaimergp
reviewed
Aug 15, 2024
Co-authored-by: jaimergp <[email protected]>
Co-authored-by: jaimergp <[email protected]>
isuruf
reviewed
Sep 16, 2024
Comment on lines
+1718
to
+1737
outputs: | ||
- name: runtime_package_name | ||
# no run_export should be added here. This package is missing the | ||
# development headers and other compilation files. | ||
# Typically this package is suffixed with `-devel` | ||
- name: development_package_name | ||
build: | ||
run_exports: | ||
# the max_pin should be adjusted | ||
- {{ pin_subpackage('runtime_package_name', max_pin='x.x') }} | ||
requirements: | ||
# Add the runtime package as a host dependency to ensure that files are deduplicated between the packages. | ||
host: | ||
- {{ pin_subpackage('runtime_package_name', exact=True) }} | ||
run: | ||
- {{ pin_subpackage('runtime_package_name', exact=True) }} | ||
- other | ||
- required | ||
- compilation | ||
- dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
outputs: | |
- name: runtime_package_name | |
# no run_export should be added here. This package is missing the | |
# development headers and other compilation files. | |
# Typically this package is suffixed with `-devel` | |
- name: development_package_name | |
build: | |
run_exports: | |
# the max_pin should be adjusted | |
- {{ pin_subpackage('runtime_package_name', max_pin='x.x') }} | |
requirements: | |
# Add the runtime package as a host dependency to ensure that files are deduplicated between the packages. | |
host: | |
- {{ pin_subpackage('runtime_package_name', exact=True) }} | |
run: | |
- {{ pin_subpackage('runtime_package_name', exact=True) }} | |
- other | |
- required | |
- compilation | |
- dependencies | |
outputs: | |
- name: libfoo | |
# no run_export should be added here. This package is missing the | |
# development headers and other compilation files. | |
- name: libfoo-devel | |
build: | |
run_exports: | |
# the max_pin should be adjusted | |
- {{ pin_subpackage('libfoo', max_pin='x.x') }} | |
requirements: | |
# Add the runtime package as a host dependency to ensure that files are deduplicated between the packages. | |
host: | |
- {{ pin_subpackage('libfoo', exact=True) }} | |
run: | |
- {{ pin_subpackage('libfoo', exact=True) }} | |
- other | |
- required | |
- compilation | |
- dependencies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist:
docs/
orcommunity/
, you have added it to the sidebar in the corresponding_sidebar.json
file