-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra context around required pip
flags
#2044
base: main
Are you sure you want to change the base?
Conversation
src/maintainer/adding_pkgs.rst
Outdated
These options should be used to ensure a clean installation of the package without its | ||
dependencies. This helps make sure that we're only including this package, | ||
and not accidentally bringing any dependencies along into the conda package. | ||
`conda-forge` configures `pip` to ensure a clean installation of the package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually conda build, not conda-forge. A link to what conda-build sets would be useful. I have not been able to find one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In gitter jakirkham
linked https://github.com/conda/conda-build/blob/061063f10c51162707c7c5253daa39b2752fcfcc/conda_build/build.py#L3169-L3189
I'll add that reference to the note here. May have to circle back on this though as pre-xmas is getting hectic...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this to conda-build
now but feel free to add the note too!
Co-authored-by: dhirschfeld <[email protected]>
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Ahhhh, I should circle back and get this over the line! The link checker seems to be failing with:
|
429s can be ignored. We spammed a bit too much because we had a few PRs running in parallel as I updated the conflicts. |
PR Checklist: