Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert marking cuTENSOR v1.7.0 build 1 as broken #710

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

leofang
Copy link
Member

@leofang leofang commented Apr 24, 2023

Now that we have cuda-version constraints set up properly:

The previous PR (#701) can be reverted.

cc: @conda-forge/cutensor @jakirkham @kkraus14 for vis

Guidelines for marking packages as broken:

  • We prefer to patch the repo data (see here)
    instead of marking packages as broken. This alternative workflow makes environments more reproducible.
  • Packages with requirements/metadata that are too strict but otherwise work are
    not technically broken and should not be marked as such.
  • Packages with missing metadata can be marked as broken on a temporary basis
    but should be patched in the repo data and be marked unbroken later.
  • In some cases where the number of users of a package is small or it is used by
    the maintainers only, we can allow packages to be marked broken more liberally.
  • We (conda-forge/core) try to make a decision on these requests within 24 hours.

What will happen when a package is marked broken?

  • Our bots will add the broken label to the package. The main label will remain on the package and this is normal.
  • Our bots will rebuild our repodata patches to remove this package from the repodata.
  • In a few hours after the anaconda.org CDN picks up the new patches, you will no longer be able to install the package from the main channel.

Checklist:

  • I want to mark a package as broken (or not broken):

    • Make sure your package is in the right spot (broken/* for adding the
      broken label, not_broken/* for removing the broken label, or token_reset/*
      for token resets)
    • Added a description of the problem with the package in the PR description.
    • Pinged the team for the package for their input.
  • I want to archive a feedstock:

    • Pinged the team for that feedstock for their input.
    • Make sure you have opened an issue on the feedstock explaining why it was archived.
    • Linked that issue in this PR description.
    • Added links to any other relevant issues/PRs in the PR description.

@leofang leofang requested a review from a team as a code owner April 24, 2023 13:28
@jakirkham jakirkham merged commit 57db4aa into conda-forge:main Apr 24, 2023
@jakirkham
Copy link
Member

Thanks Leo! 🙏

@leofang leofang deleted the unbreak_cutensor branch April 24, 2023 16:14
@leofang
Copy link
Member Author

leofang commented Apr 24, 2023

As of now (1:00pm EST, 51 mins after merging) the packages still have not shown up:

$ conda search "cutensor=1.7.0"
Loading channels: done
# Name                       Version           Build  Channel             
cutensor                     1.7.0.1      h12f7317_0  conda-forge         
cutensor                     1.7.0.1      h17a0586_0  conda-forge         
cutensor                     1.7.0.1      h1a5f58c_0  conda-forge 

@leofang
Copy link
Member Author

leofang commented Apr 24, 2023

It's up now (1:15pm EST, 66 mins after merging):

$ conda search "cutensor=1.7.0"
Loading channels: done
# Name                       Version           Build  Channel             
cutensor                     1.7.0.1      h12f7317_0  conda-forge         
cutensor                     1.7.0.1      h17a0586_0  conda-forge         
cutensor                     1.7.0.1      h1a5f58c_0  conda-forge         
cutensor                     1.7.0.1      hcb278e6_1  conda-forge 

@jakirkham
Copy link
Member

Maybe worth mentioning as another example in issue ( conda/infrastructure#740 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants