Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement toast layer from root #549

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tilucasoli
Copy link
Collaborator

Related issue

This PR refactors the showToast method and improves the ToastLayer integration within the RemixApp

Description

  • showToast: Added a new parameter useRootNavigator to specify whether the root navigator should be used when finding the ToastLayerState

Review Checklist

  • Testing: Have you tested your changes, including unit tests and integration tests for affected code?
  • Breaking Changes: Does this change introduce breaking changes affecting existing code or users?
  • Documentation Updates: Are all relevant documentation files (e.g. README, API docs) updated to reflect the changes in this PR?
  • Website Updates: Is the website containing the updates you make on documentation?

Additional Information (optional)

Is there any additional context or documentation that might be helpful for reviewers?

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
mix-docs ⬜️ Ignored (Inspect) Jan 20, 2025 8:08pm

@github-actions github-actions bot added the remix label Jan 20, 2025
@tilucasoli tilucasoli changed the title implement toast layer from root feat: implement toast layer from root Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant