Refactor docker runner: new logging system and fixed several bugs #17542
+283
−220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsanfal
approved these changes
Dec 31, 2024
perseoGI
force-pushed
the
pgi/docker-runner
branch
from
e3463bf to
b270887
Compare
perseoGI
changed the title
perseoGI
commented
Feb 3, 2025
Comment on lines
+136
to
+145
| # Runners | ||
| "runner.type": "Type of runner to use. Possible values: 'docker'", | ||
| "runner.docker.dockerfile": "Path to the Dockerfile to use in case of building a docker image", | ||
| "runner.docker.image": "Image name to download from registry or the name of the built image in case of defining dockerfile path", | ||
| "runner.docker.name": "Name of the container to be used (conan-runner-docker by default)", | ||
| "runner.docker.cache": "Host's conan cache behavior. Possible values: 'clean' (use empty cache), 'copy' (copy whole cache) or 'shared' (mount chache as shared volume)", | ||
| "runner.docker.remove": "(boolean) Remove the container after running the Conan command", | ||
| "runner.docker.configfile": "Path to a configuration file with extra parameters (https://containers.dev/implementors/json_reference/#image-specific)", | ||
| "runner.docker.build_context": "Docker build context", | ||
| "runner.docker.platform": "Docker platform to build the image for, e.g. 'linux/amd64'", |
There was a problem hiding this comment.
This should not go here, I know. But right now conan's client does not have any command to display extra information about profiles configuration.
Should we create it?
The same occurs with the SSH runner here: https://github.com/conan-io/conan/pull/17357/files#diff-c91d5fdfb0f1effa668199823027b39224920aebeb9db78f13a19abbe5e50be9R136-R139
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Fix several bugs in docker runner, added new configuration options and improved logging system
Docs: conan-io/docs#3977
platformfrom configfile and directly from profile -> this allows defining platform such aslinux/amd64on Mac Silicon systems, avoiding compilation issues related with architecturedocker.prefix to avoid collisions with other runner configurationsdevelopbranch, documenting this one.