-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add astc-codec/20190617 #2548
Add astc-codec/20190617 #2548
Conversation
An unexpected error happened and has been reported. Help is on its way! 🏇 |
An unexpected error happened and has been reported. Help is on its way! 🏇 |
All green in build 3 (
|
topics = ("conan", "astc", "codec") | ||
settings = "os", "compiler", "arch", "build_type" | ||
options = { | ||
"fPIC": [True, False], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why there is no shared option? I see no restriction: https://github.com/google/astc-codec/blob/master/src/decoder/CMakeLists.txt#L17
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The library doesn't export symbols. And CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS
introduces some linking errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I didn't find any reference about this error, but I can reproduce it, so I've opened an issue to the author: google/astc-codec#14
All green in build 4 (
|
Changes not allowed in build 5:
Split them in several pull requests if you are making changes in more than one folder. |
An unexpected error happened and has been reported. Help is on its way! 🏇 |
All green in build 7 (
|
Specify library name and version: astc-codec/cci.20190617
conan-center hook activated.