Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add astc-codec/20190617 #2548

Merged
merged 4 commits into from
Aug 28, 2020
Merged

Add astc-codec/20190617 #2548

merged 4 commits into from
Aug 28, 2020

Conversation

intelligide
Copy link
Contributor

Specify library name and version: astc-codec/cci.20190617

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@intelligide intelligide reopened this Aug 16, 2020
@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@intelligide intelligide reopened this Aug 16, 2020
@conan-center-bot
Copy link
Collaborator

All green in build 3 (30159a817eeaa7e15d5b9128efce9686e8e861c3)! 😊

uilianries
uilianries requested changes Aug 18, 2020
View reviewed changes
recipes/astc-codec/all/conanfile.py
topics = ("conan", "astc", "codec")
settings = "os", "compiler", "arch", "build_type"
options = {
"fPIC": [True, False],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why there is no shared option? I see no restriction: https://github.com/google/astc-codec/blob/master/src/decoder/CMakeLists.txt#L17

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The library doesn't export symbols. And CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS introduces some linking errors.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I didn't find any reference about this error, but I can reproduce it, so I've opened an issue to the author: google/astc-codec#14

recipes/astc-codec/all/conanfile.py Show resolved Hide resolved
@conan-center-bot
Copy link
Collaborator

All green in build 4 (dd91b9f912733e15e4e51c9a823331b21d63a95d)! 😊

@conan-center-bot
Copy link
Collaborator

Changes not allowed in build 5:

[docs/error_knowledge_base.md, recipes/astc-codec/all/CMakeLists.txt, recipes/astc-codec/all/conandata.yml, recipes/astc-codec/all/conanfile.py, recipes/astc-codec/all/test_package/CMakeLists.txt, recipes/astc-codec/all/test_package/atlas_small_4x4.astc, recipes/astc-codec/all/test_package/conanfile.py, recipes/astc-codec/all/test_package/test_package.cpp, recipes/astc-codec/config.yml, recipes/glog/all/conanfile.py, recipes/glog/all/patches/fix-cmake.patch, recipes/glog/all/test_package/CMakeLists.txt, recipes/glog/all/test_package/conanfile.py, recipes/glog/all/test_package/test_package.cpp, recipes/libsigcpp/3.0.0/conanfile.py, recipes/libsigcpp/3.0.0/test_package/CMakeLists.txt, recipes/libsigcpp/3.0.0/test_package/conanfile.py, recipes/poco/all/CMakeLists.txt, recipes/poco/all/conandata.yml, recipes/poco/all/conanfile.py, recipes/poco/all/test_package/CMakeLists.txt, recipes/poco/all/test_package/conanfile.py, recipes/restinio/all/conandata.yml, recipes/restinio/all/conanfile.py, recipes/restinio/config.yml, recipes/xkbcommon/all/conanfile.py, recipes/xkbcommon/all/test_package/CMakeLists.txt, recipes/zlib/1.2.11/conanfile.py]

Split them in several pull requests if you are making changes in more than one folder.

@uilianries uilianries closed this Aug 20, 2020
@uilianries uilianries reopened this Aug 20, 2020
@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@intelligide intelligide reopened this Aug 20, 2020
@intelligide intelligide reopened this Aug 21, 2020
@conan-center-bot
Copy link
Collaborator

All green in build 7 (580bf20cff0157e5db3f80773e069cba3e993244)! 😊

@SSE4 SSE4 requested a review from danimtb August 27, 2020 16:15
@danimtb danimtb merged commit 939d12a into conan-io:master Aug 28, 2020
@intelligide intelligide deleted the new/astc-codec/20190617 branch September 17, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@uilianries uilianries uilianries approved these changes

@danimtb danimtb danimtb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@intelligide @conan-center-bot @SSE4 @uilianries @danimtb