add scaffolding to compound styles #10
Conversation
|
Yes, here is the PR in labs repo, still a draft, but can open up in a bit |
| margin: 0 auto; | ||
| padding-right: $column-gutter; | ||
| padding-left: $column-gutter; | ||
| } |
There was a problem hiding this comment.
We definitely should not take this class, it's been super annoying to use so let's not migrate this over.
| position: relative; | ||
| max-width: 66rem; | ||
| } | ||
| .container-large { |
There was a problem hiding this comment.
Do we currently have references to these container names already in webb3? I would be scared this might break something if we already use these class names.
| max-width: $device-lg; | ||
| } | ||
|
|
||
| .row { |
There was a problem hiding this comment.
Again would want to check this class name for usage in webb3 to make sure we don't screw up any existing alignments.
| } | ||
| } | ||
|
|
||
| [class*='col'] { |
There was a problem hiding this comment.
let's do a small adjustment to match only on col-
| html, | ||
| body { | ||
| font-size: 14px; | ||
| } |
There was a problem hiding this comment.
we probably don't want this font size to propagate lest we break webb3? Also font changes like this should probably stay in typography.
| html, | ||
| body { | ||
| font-size: 15px; | ||
| } |
There was a problem hiding this comment.
dittO: we probably don't want this font size to propagate lest we break webb3? Also font changes like this should probably stay in typography.
| html, | ||
| body { | ||
| font-size: 16px; | ||
| } |
There was a problem hiding this comment.
ditt: we probably don't want this font size to propagate lest we break webb3? Also font changes like this should probably stay in typography.
Plan to decouple compound component from labs repo
https://docs.google.com/document/d/1ojRVLUZxHk_EZXSDfAdyYVymkNntk3JXmcevIn4GL6c/edit