-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update error handling #207
base: master
Are you sure you want to change the base?
Conversation
Fix L07: Outdated Solidity versions
Partial Fix: N13 - Typos
Partial Fix: L08 - Unreachable code
Partial Fix: L05 - Missing or erroneous docstrings and comments
Partial Fix: L03 - Gas inefficiencies
… error handling in safemath and others
…ller, whitepaperinterestratemodel, jumpratemodels
…sts - needs testing work
Thanks for taking an interest in upgrading these contracts! So equilibria was actually encouraged not to upgrade solc, since the contracts that would be upgraded were deployed with the version they were deployed with. The efficient errors, are a function of the solc version as well, I suppose. I wonder what the net gas savings are beyond the recent upgrades, but the cost would be considerable to audit these changes and upgrade all the markets again, so I wouldn't really count on getting them made. This repository is largely becoming legacy, in favor of https://github.com/compound-finance/comet, where there's lots of new and exciting development to be done, so I'd recommend checking it out if you haven't yet! |
Updated contracts throughout compound protocol, building on the work done by equilibria-xyz's CToken Cleanup that was merged:
Update error handling to modern standards for solidity v0.8.10
Reduce the gas costs for contract deployments & users through efficient if () revert customError();
Reorganize interfaces into standard format, pulling them out of contract files
Reduce the reliance upon ErrorReporter.sol where feasible
edit: includes corrections to a few additional contracts