Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error handling #207

Open
wants to merge 45 commits into
base: master
Choose a base branch
from

Conversation

ZrowGz
Copy link

@ZrowGz ZrowGz commented Jun 23, 2022

Updated contracts throughout compound protocol, building on the work done by equilibria-xyz's CToken Cleanup that was merged:

Update error handling to modern standards for solidity v0.8.10
Reduce the gas costs for contract deployments & users through efficient if () revert customError();
Reorganize interfaces into standard format, pulling them out of contract files
Reduce the reliance upon ErrorReporter.sol where feasible

edit: includes corrections to a few additional contracts

arjun-io and others added 30 commits August 29, 2021 15:05
Partial Fix: L05 - Missing or erroneous docstrings and comments
Partial Fix: L03 - Gas inefficiencies
@jflatow
Copy link
Contributor

jflatow commented Jul 7, 2022

Updated contracts throughout compound protocol, building on the work done by equilibria-xyz's CToken Cleanup that was merged:

Update error handling to modern standards for solidity v0.8.10 Reduce the gas costs for contract deployments & users through efficient if () revert customError(); Reorganize interfaces into standard format, pulling them out of contract files Reduce the reliance upon ErrorReporter.sol where feasible

edit: includes corrections to a few additional contracts

Thanks for taking an interest in upgrading these contracts! So equilibria was actually encouraged not to upgrade solc, since the contracts that would be upgraded were deployed with the version they were deployed with. The efficient errors, are a function of the solc version as well, I suppose. I wonder what the net gas savings are beyond the recent upgrades, but the cost would be considerable to audit these changes and upgrade all the markets again, so I wouldn't really count on getting them made. This repository is largely becoming legacy, in favor of https://github.com/compound-finance/comet, where there's lots of new and exciting development to be done, so I'd recommend checking it out if you haven't yet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants