Ignore orders for delete_all/update_all queries.

lib/composite_primary_keys/relation.rb

@@ -37,7 +37,6 @@ def update_all(updates)
 
       stmt.take(arel.limit)
       stmt.offset(arel.offset)
-      stmt.order(*arel.orders)
 
       if updates.is_a?(Hash)
         if klass.locking_enabled? &&
@@ -81,7 +80,6 @@ def delete_all
 
       stmt.take(arel.limit)
       stmt.offset(arel.offset)
-      stmt.order(*arel.orders)
 
       affected = klass.connection.delete(stmt, "#{klass} Destroy")
 

test/fixtures/tariff.rb

@@ -1,5 +1,6 @@
 class Tariff < ActiveRecord::Base
-	self.primary_keys = [:tariff_id, :start_date]
-	has_many :product_tariffs, :foreign_key => [:tariff_id, :tariff_start_date], :dependent => :delete_all
-	has_many :products, :through => :product_tariffs, :foreign_key => [:tariff_id, :tariff_start_date]
+  self.primary_keys = [:tariff_id, :start_date]
+  has_many :product_tariffs, :foreign_key => [:tariff_id, :tariff_start_date], :dependent => :delete_all
+  has_many :products, :through => :product_tariffs, :foreign_key => [:tariff_id, :tariff_start_date]
+  default_scope { order(created_at: :asc) }
 end

test/test_calculations.rb

@@ -12,7 +12,7 @@ def test_count
     expected = {Date.today => 2,
                 Date.today.next => 1}
 
-    assert_equal(expected, Tariff.group(:start_date).count)
+    assert_equal(expected, Tariff.unscoped.group(:start_date).count)
   end
 
   def test_count_distinct

test/test_delete.rb

@@ -30,6 +30,13 @@ def test_delete_all
     assert_equal(5, deleted)
   end
 
+  def test_delete_all_default_order
+    refute_empty(Tariff.all)
+    deleted = Tariff.delete_all
+    assert_empty(Tariff.all)
+    assert_equal(3, deleted)
+  end
+
   def test_delete_all_with_join
     tested_delete_all = false
     Arel::Table.engine = nil # should not rely on the global Arel::Table.engine

test/test_update.rb

@@ -73,6 +73,14 @@ def test_update_all
     end
   end
 
+  def test_update_all_default_order
+    Tariff.update_all(amount: 1337)
+
+    Tariff.all.each do |reference_code|
+      assert_equal(1337, reference_code.amount)
+    end
+  end
+
   def test_update_all_join
     tested_update_all = false
     Arel::Table.engine = nil # should not rely on the global Arel::Table.engine
@@ -100,4 +108,4 @@ def test_update_with_uniqueness
     assignment.save!
     assert_equal(room_2, assignment.room)
   end
-end
+end