Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMP: Fix configuration without explicitly setting CTK_QT_VERSION #1148

Merged
merged 1 commit into from
Oct 25, 2023
Merged

COMP: Fix configuration without explicitly setting CTK_QT_VERSION #1148

merged 1 commit into from
Oct 25, 2023

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Oct 25, 2023

Address a regression introduced in a0e74a0 (COMP: Update CMake files removing support for Qt 4.x) by fixing the following error reported when configuring without explicitly setting CTK_QT_VERSION:

cmake \
  -DQt5_DIR:PATH=$Qt5_DIR \
  -DCMAKE_BUILD_TYPE:STRING=Release \
  ../CTK

[...]
-- Checking if --no-as-needed linker flag is required - no
-- CTK_LIB_Core_WITH_BFD_SHARED is OFF
-- CTK_LIB_Core_WITH_BFD_STATIC is OFF
CMake Error at Libs/Visualization/VTK/Widgets/target_libraries.cmake:15 (message):
  Support for this Qt is not implemented
Call Stack (most recent call first):
  CMake/ctkMacroTargetLibraries.cmake:131 (include)
  CMake/ctkFunctionGenerateDGraphInput.cmake:78 (ctkFunctionCollectTargetLibraryNames)
  CMakeLists.txt:844 (ctkFunctionGenerateDGraphInput)
[...]

@jcfr
COMP: Fix configuration without explicitly setting CTK_QT_VERSION
aa98691 
Address a regression introduced in a0e74a0 (COMP: Update CMake files
removing support for Qt 4.x) by fixing the following error reported when
configuring without explicitly setting CTK_QT_VERSION:

```
cmake \
  -DQt5_DIR:PATH=$Qt5_DIR \
  -DCMAKE_BUILD_TYPE:STRING=Release \
  ../CTK

[...]
-- Checking if --no-as-needed linker flag is required - no
-- CTK_LIB_Core_WITH_BFD_SHARED is OFF
-- CTK_LIB_Core_WITH_BFD_STATIC is OFF
CMake Error at Libs/Visualization/VTK/Widgets/target_libraries.cmake:15 (message):
  Support for this Qt is not implemented
Call Stack (most recent call first):
  CMake/ctkMacroTargetLibraries.cmake:131 (include)
  CMake/ctkFunctionGenerateDGraphInput.cmake:78 (ctkFunctionCollectTargetLibraryNames)
  CMakeLists.txt:844 (ctkFunctionGenerateDGraphInput)
[...]
```
@jcfr jcfr enabled auto-merge (rebase) October 25, 2023 19:02
@jcfr jcfr merged commit b76c386 into commontk:master Oct 25, 2023
1 check passed
@jcfr jcfr deleted the fix-configuration-without-explicit-setting-of-CTK_QT_VERSION branch October 25, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jcfr