Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate calls to INPUT_TYPES #6249

Merged

Conversation

catboxanon
Copy link
Contributor

Title. Provides a speed up for certain nodes, such as those that perform file system ops without a cache, i.e. LoadImage

On my system, running a cached workflow with 10 LoadImage nodes and 10 PreviewImage nodes takes 0.08 seconds without this PR, and 0.04 seconds with.

Copy link
Collaborator

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huchenlei huchenlei added Good PR This PR looks good to go, it needs comfy's final review. Important Performance Performance related issue. labels Dec 29, 2024
@comfyanonymous comfyanonymous merged commit 82ecb02 into comfyanonymous:master Dec 30, 2024
11 checks passed
@catboxanon catboxanon deleted the fix/dup-input_types-call branch December 30, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good PR This PR looks good to go, it needs comfy's final review. Important Performance Performance related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants