-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate wiki-link plugin #51
Conversation
We can fix the build failure caused by the broken link check by using If you return an empty array from This also allows us to explicitly set it up so that broken wiki links will link to a page describing how to add a new page, without requiring us to interfere with the default 404 behavior, which we may want to preserve. You can see it in action in the first two links present on the prototype wiki. |
This also does not have feature parity with the prototype version. This is probably my fault, as while I named the issue "port and..." I failed to specify in the issue body what porting meant and that an existing working version even existed. I'd like to see support for an array of custom link text (e.g. we might want Other than that one thing, this is a significantly better version than the one I made. The wrapper is very clean, and my fears of harming maintainability are assuaged. Nice work. |
Co-authored-by: Daniel Swann <[email protected]>
Co-authored-by: Daniel Swann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes made, default page feature added, looks good.
This PR:
I've used TypeScript for this, which builds fine with our current configuration, and can of course be switched to JS if needed.
Some items not in scope for this PR:
Spaces are not replaced when checking/generating slugs in the page name resolver, we need a policy for filenames. (affects line 52,slugReference
)Would be nice for the 404 page to include a link to create the page on github.addressed alreadyFootnotes
Unlisted pages https://docusaurus.io/blog/releases/3.0#unlisted-content ↩