Add note for onAdd's second param #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for this @francislavoie 🎉 |
endel
added a commit
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to colyseus/schema#147
Currently, this second param is undocumented, I had to dig through github issues to find the solution for my problem.
This note might not be quite right, it assumes the TypeScript implementation. Do other langs behave the same, do they have the same 2nd param?
The fn signature should probably be mentioned in some way or another. And I think it should be mentioned that
listen()can have this same problem it seems (causing alisten -> onAddnesting to causeonAddto still trigger multiple times if the data existed before the user joins the room).