Fix various quality issues.

colour-science · Aug 27, 2023 · 3c02be2 · 3c02be2
1 parent 9da618d
commit 3c02be2
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 13 deletions.
diff --git a/colour_hdri/__init__.py b/colour_hdri/__init__.py
@@ -251,7 +251,7 @@
 try:
     _version: str = (
         subprocess.check_output(
-            ["git", "describe"],
+            ["git", "describe"],  # noqa: S603,S607
             cwd=os.path.dirname(__file__),
             stderr=subprocess.STDOUT,
         )

diff --git a/colour_hdri/process/dng.py b/colour_hdri/process/dng.py
@@ -289,7 +289,7 @@ def convert_raw_files_to_dng_files(
             ),
         ]
 
-        subprocess.call(command, shell=_IS_WINDOWS_PLATFORM)
+        subprocess.call(command, shell=_IS_WINDOWS_PLATFORM)  # noqa: S603
 
         dng_files.append(dng_file)
 
@@ -354,7 +354,7 @@ def convert_dng_files_to_intermediate_files(
             ),
         ]
 
-        subprocess.call(command, shell=_IS_WINDOWS_PLATFORM)
+        subprocess.call(command, shell=_IS_WINDOWS_PLATFORM)  # noqa: S603
 
         tiff_file = os.path.join(
             output_directory, os.path.basename(intermediate_file)

diff --git a/colour_hdri/recovery/tests/test_recovery.py b/colour_hdri/recovery/tests/test_recovery.py
@@ -106,7 +106,7 @@ def test_highlights_recovery_blend(self):
             ),
         ]
 
-        subprocess.call(command)
+        subprocess.call(command)  # noqa: S603
 
         test_tiff_file = read_image(
             str(re.sub("\\.CR2$", ".tiff", test_raw_file))
@@ -168,7 +168,7 @@ def test_highlights_recovery_LCHab(self):
             ),
         ]
 
-        subprocess.call(command)
+        subprocess.call(command)  # noqa: S603
 
         test_tiff_file = read_image(
             str(re.sub("\\.CR2$", ".tiff", test_raw_file))

diff --git a/colour_hdri/utilities/exif.py b/colour_hdri/utilities/exif.py
@@ -265,7 +265,7 @@ def read_exif_tags(image: str) -> defaultdict:
     lines = str(
         subprocess.check_output(
             [EXIF_EXECUTABLE, "-D", "-G", "-a", "-u", "-n", image],
-            shell=_IS_WINDOWS_PLATFORM,
+            shell=_IS_WINDOWS_PLATFORM,  # noqa: S603
         ),
         "utf-8",
         "ignore",
@@ -309,7 +309,9 @@ def copy_exif_tags(source: str, target: str) -> bool:
 
     arguments = [EXIF_EXECUTABLE, "-overwrite_original", "-TagsFromFile"]
     arguments += [source, target]
-    subprocess.check_output(arguments, shell=_IS_WINDOWS_PLATFORM)
+    subprocess.check_output(
+        arguments, shell=_IS_WINDOWS_PLATFORM  # noqa: S603
+    )
 
     return True
 
@@ -356,7 +358,7 @@ def delete_exif_tags(image: str) -> bool:
 
     subprocess.check_output(
         [EXIF_EXECUTABLE, "-overwrite_original", "-all=", image],
-        shell=_IS_WINDOWS_PLATFORM,
+        shell=_IS_WINDOWS_PLATFORM,  # noqa: S603
     )
 
     return True
@@ -382,7 +384,8 @@ def read_exif_tag(image: str, tag: str) -> str:
     value = (
         str(
             subprocess.check_output(
-                [EXIF_EXECUTABLE, f"-{tag}", image], shell=_IS_WINDOWS_PLATFORM
+                [EXIF_EXECUTABLE, f"-{tag}", image],
+                shell=_IS_WINDOWS_PLATFORM,  # noqa: S603
             ),
             "utf-8",
             "ignore",
@@ -426,6 +429,8 @@ def write_exif_tag(image: str, tag: str, value: str) -> bool:
 
     arguments = [EXIF_EXECUTABLE, "-overwrite_original"]
     arguments += [f"-{tag}={value}", image]
-    subprocess.check_output(arguments, shell=_IS_WINDOWS_PLATFORM)
+    subprocess.check_output(
+        arguments, shell=_IS_WINDOWS_PLATFORM  # noqa: S603
+    )
 
     return True
diff --git a/utilities/export_todo.py b/utilities/export_todo.py
@@ -66,15 +66,15 @@ def extract_todo_items(root_directory: str) -> dict:
             if not filename.endswith(".py"):
                 continue
 
-            filename = os.path.join(root, filename)
+            filename = os.path.join(root, filename)  # noqa: PLW2901
             with codecs.open(filename, encoding="utf8") as file_handle:
                 content = file_handle.readlines()
 
             in_todo = False
             line_number = 1
             todo_item = []
             for i, line in enumerate(content):
-                line = line.strip()
+                line = line.strip()  # noqa: PLW2901
                 if line.startswith("# TODO:"):
                     in_todo = True
                     line_number = i + 1

diff --git a/utilities/unicode_to_ascii.py b/utilities/unicode_to_ascii.py
@@ -55,7 +55,7 @@ def unicode_to_ascii(root_directory: str):
             if filename == "unicode_to_ascii.py":
                 continue
 
-            filename = os.path.join(root, filename)
+            filename = os.path.join(root, filename)  # noqa: PLW2901
             with codecs.open(filename, encoding="utf8") as file_handle:
                 content = file_handle.read()