Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a proper error type from set_virtual_terminal #155

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Dec 11, 2023

Follow-up to #105. This is a breaking change.

@kurtlawrence kurtlawrence added the breaking Will need a major version bump label Dec 11, 2023
@kurtlawrence
Copy link
Collaborator

I've made a v3 branch for breaking changes. Could you please target the PR towards that branch?

@madsmtm madsmtm changed the base branch from master to v3 December 12, 2023 03:28
@spenserblack
Copy link
Collaborator

Oops, sorry, my attention has been on more recently active PRs. The master branch is now on v3, so could you target that for your PR and make any necessary changes (the changelog, for example)?

@madsmtm madsmtm force-pushed the proper-error-windows branch from 3456438 to 133ae17 Compare January 7, 2025 17:18
@madsmtm madsmtm changed the base branch from v3 to master January 7, 2025 17:18
@madsmtm
Copy link
Contributor Author

madsmtm commented Jan 7, 2025

Done

@spenserblack spenserblack self-assigned this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Will need a major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants