-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support for ARIA attributes (props) (#37)
* Add `aria-attributes` dependency * Inline ARIA props and document why * Generate ARIA props For now, they are all given the `String` type. After spot checking a few on MDN, that is mostly accurate, even for seemingly numeric values such `aria-valuemin`: https://developer.mozilla.org/en-US/docs/Web/API/Element/ariaValueMin#value NOTE: Despite React using `camelCase` for most props, ARIA props are indeed `kebab-case`: - https://react.dev/learn/writing-markup-with-jsx#3-camelcase-salls-most-of-the-things:~:text=the%20browser%20console.-,Pitfall,-For%20historical%20reasons - https://legacy.reactjs.org/docs/accessibility.html#wai-aria This could be improved with the following type definitions, but we’ll leave this to the implementing developer now to check support in the browser: https://use-form.netlify.app/interfaces/_node_modules__types_react_index_d_.react.ariaattributes * Quote `aria-*` props Co-authored-by: Fyodor Soikin <[email protected]> * Add line to changelog --------- Co-authored-by: Fyodor Soikin <[email protected]> Co-authored-by: Shannon Broekhoven <[email protected]>
- Loading branch information
1 parent
1d604bf
commit adc1fd4
Showing
7 changed files
with
6,125 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,11 @@ | ||
# purescript-elmish-html | ||
|
||
## 0.8.3 | ||
|
||
### Added | ||
|
||
- Support for ARIA attributes | ||
|
||
## 0.8.2 | ||
|
||
### Changed | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
[ | ||
"aria-activedescendant", | ||
"aria-atomic", | ||
"aria-autocomplete", | ||
"aria-busy", | ||
"aria-checked", | ||
"aria-colcount", | ||
"aria-colindex", | ||
"aria-colspan", | ||
"aria-controls", | ||
"aria-current", | ||
"aria-describedby", | ||
"aria-details", | ||
"aria-disabled", | ||
"aria-dropeffect", | ||
"aria-errormessage", | ||
"aria-expanded", | ||
"aria-flowto", | ||
"aria-grabbed", | ||
"aria-haspopup", | ||
"aria-hidden", | ||
"aria-invalid", | ||
"aria-keyshortcuts", | ||
"aria-label", | ||
"aria-labelledby", | ||
"aria-level", | ||
"aria-live", | ||
"aria-modal", | ||
"aria-multiline", | ||
"aria-multiselectable", | ||
"aria-orientation", | ||
"aria-owns", | ||
"aria-placeholder", | ||
"aria-posinset", | ||
"aria-pressed", | ||
"aria-readonly", | ||
"aria-relevant", | ||
"aria-required", | ||
"aria-roledescription", | ||
"aria-rowcount", | ||
"aria-rowindex", | ||
"aria-rowspan", | ||
"aria-selected", | ||
"aria-setsize", | ||
"aria-sort", | ||
"aria-valuemax", | ||
"aria-valuemin", | ||
"aria-valuenow", | ||
"aria-valuetext", | ||
"role" | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.