Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a hydra-js package for volto-hydra #61

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Conversation

MAX-786
Copy link
Member

@MAX-786 MAX-786 commented Jun 20, 2024

No description provided.

@MAX-786 MAX-786 self-assigned this Jun 20, 2024
@MAX-786 MAX-786 marked this pull request as ready for review June 20, 2024 10:22
@MAX-786 MAX-786 requested a review from JeffersonBledsoe June 20, 2024 10:22
Copy link
Member

@JeffersonBledsoe JeffersonBledsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MAX-786 Just the one minor thing, thanks for doing this :)

packages/hydra-js/package.json Outdated Show resolved Hide resolved
@MAX-786 MAX-786 requested a review from JeffersonBledsoe June 20, 2024 12:41
@JeffersonBledsoe
Copy link
Member

@MAX-786 Any imports will need to use the package from now on. Nothing in the volto-hydra addon use this file right? It's all to be used on the integration side?

@MAX-786
Copy link
Member Author

MAX-786 commented Jun 20, 2024

@JeffersonBledsoe I am ready to create a draft for block's border which will be changing hydra.js, so can this be merged now

@MAX-786
Copy link
Member Author

MAX-786 commented Jun 20, 2024

Nothing in the volto-hydra addon use this file right? It's all to be used on the integration side?

Yepp, its needed on frontend only

@JeffersonBledsoe JeffersonBledsoe merged commit c04b829 into main Jun 20, 2024
1 check passed
@JeffersonBledsoe JeffersonBledsoe deleted the add-hydra--package branch June 20, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants