-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline link formatting #126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/hydra-js/hydra.js
- sync wasn't proper b/w hydrajs and adminUI (fixed by adding proper 2 way link) - slate field was not getting content editable in different frontends - Follow the guidelines
…le DOM thus removing the toolbar)
djay
reviewed
Aug 23, 2024
<RichText v-for="child in subs" :key="child.nodeId" :node="child" /> | ||
</f7-link> | ||
</template> | ||
<span v-else-if="!node.type" :data-node-id="node.nodeId"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think it's not needed to force wrapping text in a span and give it a node-id. I think there is enough information conveyed to hydra to work out where the cursor is without having to force more ugly markup.
But this can be looked at later. it's fine for now.
djay
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35
This PR should :
<b>, <em>
etc.) into linkToolbar fix
This PR also includes some fixes for the below edge cases:
The toolbar is added before the frontend re-renders, causing it to disappear. The solution is to add the toolbar after the re-render using a timeout, but this introduces a slight visual delay
what is happening is that
so what we can do is that we add toolbar only when the data is sent to the frontend and we are sure that the html is re-rendered and then after this we add the toolbar so now it will not get removed, i did this by setting a 0 timeout so adding toolbar goes to another cycle but this adds up a visual delay of toolbar appearing