Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge file structure with overview section #739

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

natashamm
Copy link
Contributor

@natashamm natashamm commented Oct 31, 2024

From #626

I didn't change much of the content for now.


📚 Documentation preview 📚: https://icalendar--739.org.readthedocs.build/

@coveralls
Copy link

coveralls commented Oct 31, 2024

Pull Request Test Coverage Report for Build 11668697245

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.528%

Totals Coverage Status
Change from base Build 11530774980: 0.0%
Covered Lines: 3602
Relevant Lines: 3690

💛 - Coveralls

Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some syntax improvements, grammar fixes. Please spell out words, as it makes it easier to translate them.

docs/usage.rst Outdated Show resolved Hide resolved
docs/usage.rst Outdated Show resolved Hide resolved
Each content line defines a property that has 3 parts (name, parameters,
values). Parameters are optional.
It consists of **content lines**,
with each content line defining a property that has 3 parts: name, parameters and value. Parameters are optional.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with each content line defining a property that has 3 parts: name, parameters and value. Parameters are optional.
with each content line defining a property that has 3 parts: name, parameters, and values. Parameters are optional.

docs/usage.rst Outdated Show resolved Hide resolved

A simple content line with only name and value could look like this::
Example 1: a simple content line (with only name and value)::

BEGIN:VCALENDAR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For each example, the default lexer is Python by virtue of the preceding line's ::, but should be text. Would you please update each example with this pattern, replacing :: with ., inserting the code-block directive, and indenting by four spaces the code example?

Suggested change
BEGIN:VCALENDAR
.. code-block:: text
BEGIN:VCALENDAR

docs/usage.rst Outdated Show resolved Hide resolved
docs/usage.rst Outdated Show resolved Hide resolved

On a higher level, you can think of iCalendar files structured as having components and sub components.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
On a higher level, you can think of iCalendar files structured as having components and sub components.
On a higher level, you can think of iCalendar files' structure as having components and subcomponents.

--------
A component will have properties with values. The values
have special types, like integer, text, and datetime. These values are
encoded in a special text format in an iCalendar file. This package contains methods for converting to and from these encodings.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never been a fan of arbitrary line wrapping in narrative documentation, but if we're going to do that, then we should be consistent.

Narrative documentation is not code, and we're no longer constrained by 80-character terminal sessions over dial-up modems when editing. To me, it makes more sense to have one sentence per line, eliminating the need for line wrapping and making for easier review of diffs, but I won't push for it.

docs/usage.rst Outdated Show resolved Hide resolved
natashamm and others added 2 commits November 4, 2024 08:35
Co-authored-by: Steve Piercy <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
@niccokunzmann
Copy link
Member

I think, the docs pass the build. @natashamm , could you add a changelog entry? Let me know when you are done improving the docs! Thanks :)

@niccokunzmann
Copy link
Member

Also, you can look here to see if it is how you like it: https://icalendar--739.org.readthedocs.build/en/739/usage.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants