Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff format tests #719

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Ruff format tests #719

merged 5 commits into from
Oct 16, 2024

Conversation

niccokunzmann
Copy link
Member

@niccokunzmann niccokunzmann commented Oct 9, 2024

This is a contribution to #672 and formats the test files.

Some errors are still in the tests files. I started with formatting these as they likely do not cause merge conflicts for future contributions.


📚 Documentation preview 📚: https://icalendar--719.org.readthedocs.build/

@coveralls
Copy link

coveralls commented Oct 9, 2024

Pull Request Test Coverage Report for Build 11364762185

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 674 of 677 (99.56%) changed or added relevant lines in 41 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 97.489%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/icalendar/tests/hypothesis/test_fuzzing.py 6 7 85.71%
src/icalendar/tests/test_cli_tool.py 10 11 90.91%
src/icalendar/tests/test_with_doctest.py 5 6 83.33%
Files with Coverage Reduction New Missed Lines %
src/icalendar/caselessdict.py 1 92.41%
Totals Coverage Status
Change from base Build 11364750615: 0.1%
Covered Lines: 3517
Relevant Lines: 3604

💛 - Coveralls

@niccokunzmann
Copy link
Member Author

@jacadzaca, if you have time, please review it.
@stevepiercy, this is for #672 in which we had a discussion about code styling.

Copy link
Member

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper grammar on change log. If tests pass, LGTM!

CHANGES.rst Outdated Show resolved Hide resolved
Co-authored-by: Steve Piercy <[email protected]>
@niccokunzmann
Copy link
Member Author

@stevepiercy Thanks for the review! When the tests pass, I will merge it.

@niccokunzmann niccokunzmann merged commit 6efa2d3 into collective:main Oct 16, 2024
15 checks passed
@niccokunzmann niccokunzmann deleted the ruff-tests branch October 16, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants