Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 9074 #717

Merged
merged 8 commits into from
Oct 15, 2024
Merged

RFC 9074 #717

merged 8 commits into from
Oct 15, 2024

Conversation

niccokunzmann
Copy link
Member

@niccokunzmann niccokunzmann commented Oct 7, 2024

This intends to fix #657.

It contributes to #716 by allowing the ACKNOWLEDGED property to be a time, not just text.


📚 Documentation preview 📚: https://icalendar--717.org.readthedocs.build/

@coveralls
Copy link

coveralls commented Oct 7, 2024

Pull Request Test Coverage Report for Build 11348855228

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 97.349%

Totals Coverage Status
Change from base Build 11317448813: 0.01%
Covered Lines: 3520
Relevant Lines: 3612

💛 - Coveralls

@niccokunzmann
Copy link
Member Author

Please review ❤️

@niccokunzmann niccokunzmann merged commit 5b974d9 into collective:main Oct 15, 2024
9 of 10 checks passed
@niccokunzmann niccokunzmann deleted the issue-657-rfc-9074 branch October 15, 2024 15:02
@niccokunzmann
Copy link
Member Author

Merging for progress. 1 week is over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC 9074 - Alarm Extension
2 participants