-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config with default template 5d22fbf8 #166
Conversation
@petschki short explanation for the changes by me. the command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions:
- what about the second "multiple" in the
to
field? - if multiple is missing, are there problems when saving multiple values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I see now that the multiple
attribute is set in tal:attributes
so its OK to remove it from the markup.
But TBH it smells a bit like a bug in Chameleon template rendering engine, because if I do multiple=""
in the widget markup it gets replaced correctly with multiple="multiple"
(thats what z3c.form OrderedSelect
widget defines here: https://github.com/zopefoundation/z3c.form/blob/master/src/z3c/form/browser/orderedselect.py#L36) -> but according to the specs, those "boolean html attributes" should be handled correctly if they are present without a value (https://developer.mozilla.org/en-US/docs/Glossary/Boolean/HTML)
So if you remove the second multiple in the to
field too, this is approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
related 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
related 😉
Okay, a new task for the week ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Root cause: malthe/chameleon#429
multiple
rendering is wrong in the widget, no multiple selection possible #165