Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix keyword comparison #161

Merged
merged 4 commits into from
Jul 19, 2024
Merged

fix keyword comparison #161

merged 4 commits into from
Jul 19, 2024

Conversation

mamico
Copy link
Contributor

@mamico mamico commented Jul 19, 2024

Fix a bug that occurred when two taxonomy keywords at the same level started the same way.

@mamico mamico requested review from petschki and cekk July 19, 2024 15:33
@mamico mamico requested review from petschki and removed request for petschki July 19, 2024 15:47
src/collective/taxonomy/indexer.py Outdated Show resolved Hide resolved
@petschki
Copy link
Member

petschki commented Jul 19, 2024

Note: the breaking circular dependency check is unrelated to this PR. We should disable it here until the core packages are clean.

EDIT: to disable it, remove the line in .meta.toml here https://github.com/collective/collective.taxonomy/blob/master/.meta.toml#L16 and run plone/meta again.

@mamico mamico requested a review from petschki July 19, 2024 18:19
@petschki petschki merged commit c78a264 into master Jul 19, 2024
9 checks passed
@petschki petschki deleted the fix_startswith branch July 19, 2024 18:28
@mamico
Copy link
Contributor Author

mamico commented Jul 21, 2024

Thanks @petschki. Could you do a new release on pypi?

@petschki
Copy link
Member

done https://pypi.org/project/collective.taxonomy/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants