-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker configuration #102
base: master
Are you sure you want to change the base?
Conversation
sry ... I'm not the right reviewer for this changes |
@petschki thanks if you want to try, just install docker and docker compose: and run the commands: make docker-build
make docker-start In a new clone of this addon. The idea here is to have same environment for development, CI, tests, staging and production, making it easier to get the Plone running. Plone Docker image comes with almost everything needed to run Plone, run dependencies and cache. Regards |
After merge this branch will try to prepare a new branch to test Travis with Docker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rodfersou could you please have a look on my last commit to resolve the conflicts in the Makefile. If thats all fine, let's merge this. |
Not sure if we still need: VIRTUALENV_NOT_INSTALLED, i changed the way the venv is created to the Python3 way and also create in venv not in ".". |
there seem to be version issues with plone.recipe.codeanalysis, i'm not a big fan of this package amnyway, usually i use a tox setup with some flake8 directly. But we don't have this setup here right now. |
No description provided.