fixes reported by static code analysis

src/collective/taxonomy/browser.py

@@ -25,8 +25,7 @@ def taxonomiesForContext(self, short_names=[]):
                     results.append(self.translate(
                         taxon,
                         domain='collective.taxonomy.' + short_name
-                    )
-                )
+                    ))
 
         return results
 

src/collective/taxonomy/controlpanel.py

@@ -1,12 +1,11 @@
-from plone.app.controlpanel.form import ControlPanelForm, ControlPanelView
+from plone.app.controlpanel.form import ControlPanelForm
 from plone.app.form.widgets.multicheckboxwidget import MultiCheckBoxWidget \
     as BaseMultiCheckBoxWidget
 from plone.behavior.interfaces import IBehavior
 
 from Products.CMFPlone.interfaces import IPloneSiteRoot
 from Products.CMFDefault.formlib.schema import ProxyFieldProperty
 from Products.CMFDefault.formlib.schema import SchemaAdapterBase
-from Products.Five.browser.pagetemplatefile import ViewPageTemplateFile
 from Products.statusmessages.interfaces import IStatusMessage
 
 from zope.formlib import form as formlib

src/collective/taxonomy/interfaces.py

@@ -112,4 +112,3 @@ def taxonomiesForContext(self):
 
     def translate(self, msgid, domain, target_language):
         """ """
-

src/collective/taxonomy/json.py

@@ -127,8 +127,7 @@ def __call__(self):
             'status': 'error',
             'message': translate(
                 _("There seems to have been an error."),
-                context=request)
-            })
+                context=request)})
 
     def generate_data_for_taxonomy(self, parsed_data, language,
                                    path=PATH_SEPARATOR):

src/collective/taxonomy/testing.py

@@ -1,5 +1,4 @@
 # -*- coding: utf-8 -*-
-from plone import api
 from plone.app.testing import IntegrationTesting
 from plone.app.testing import PLONE_FIXTURE
 from plone.app.testing import PloneSandboxLayer

src/collective/taxonomy/upgradesteps.py

@@ -1,9 +1,7 @@
-from zope.component import getUtilitiesFor
-
 from logging import getLogger
-
 from plone.behavior.interfaces import IBehavior
 
+
 log = getLogger('collective.taxonomy:upgrades')
 
 

src/collective/taxonomy/utility.py

@@ -159,7 +159,7 @@ def clean(self):
         self.data.clear()
 
     def add(self, language, identifier, path):
-        if not language in self.data:
+        if language not in self.data:
             self.data[language] = OOBTree()
 
         self.data[language][path] = identifier

src/collective/taxonomy/vdex.py

@@ -73,7 +73,7 @@ def buildFinalPathIndex(self, node, tree):
 
         for i in node:
             # leaf
-            if not i in tree:
+            if i not in tree:
                 results[i] = {}
             else:
                 results[i] = self.buildFinalPathIndex(tree[i], tree)
@@ -88,7 +88,7 @@ def buildPathIndex(self):
                     parent_path = path.split(PATH_SEPARATOR)[:-1]
                     parent_identifier = children.get(
                         PATH_SEPARATOR.join(parent_path))
-                    if not parent_identifier in pathIndex:
+                    if parent_identifier not in pathIndex:
                         pathIndex[parent_identifier] = set()
                     pathIndex[parent_identifier].add(identifier)
 
@@ -130,7 +130,7 @@ def makeTranslationTable(self):
 
         for (language, children) in self.taxonomy.data.items():
             for (path, identifier) in children.items():
-                if not identifier in translationTable:
+                if identifier not in translationTable:
                     translationTable[identifier] = {}
 
                 translationTable[identifier][language] = \

travis.cfg

@@ -14,7 +14,7 @@ parts +=
 [code-analysis]
 directory = ${buildout:directory}/src/collective/taxonomy
 pre-commit-hook = False
-flake8-ignore = E501
+flake8-ignore = E501,C901
 debug-statements = True
 deprecated-aliases = True
 imports = True