ci: Bump rust toolchain to 1.83 #39
Conversation
.github/workflows/ci.yml
Outdated
| @@ -16,16 +16,19 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - uses: dtolnay/[email protected] | |||
| - uses: dtolnay/rust-toolchain@master # avoid the tag here to prevent dependabot from updating it | |||
There was a problem hiding this comment.
this might be a bad idea if the base action has a breaking change across major versions (which it's allowed to do).
in the year 2024 it would probably be worth just switching to actions-rust-lang/setup-rust-toolchain which actually has a normal versioning scheme (i.e. it doesn't bump the major version of every rust update).
There was a problem hiding this comment.
I've switched it to actions-rust-lang/setup-rust-toolchain.
There was a problem hiding this comment.
@refi64 do you have comparison between both actions apart from your matter-of-fact type statement? I'm not familiar with actions-rust-lang so i'm not sure what switching brings us? It does seem less popular, but that's not necessarily a good indication.
fwiw dtolnay/rust-toolchain@master pattern is specifically documented by that action. And i'm not a fan of a single crate doing a different action then all the others :p (ofcourse if there is a real rationale, we can swtich them all)
Matching Debian testing Switch rust action to `actions-rust-lang/setup-rust-toolchain@v1`.
As suggested by clippy
ColinKinloch
force-pushed
the
bump_rust
branch
from
abcd0d1 to
8290abe
Compare
Matching Debian testing
Update rust toolchain action to avoid dependabot updates
This MR also contains clippys suggestions:
is_some_andFileEntryas unusedClippy is also printing:
warning: the following packages contain code that will be rejected by a future version of Rust: buf_redux v0.8.4, multipart v0.18.0, nom v5.1.2, quick-xml v0.22.0, traitobject v0.1.0, typemap v0.3.3
quick-xml is a dependency of https://github.com/collabora/open-build-service-rs which I notice doesn't have dependabot enabled.