-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support in WSS #308
base: main
Are you sure you want to change the base?
Add support in WSS #308
Conversation
@Amitabitbul Not sure why we would remove the completed flag, it helps in only adding the completed segments to the srt file. |
This helps in changing the server params to change the number of clients and the amount of time a client is allowed to stay connected to the server. |
I will remove it, I needed it only in my project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WSS changes only
@Amitabitbul Can you check again that we dont remove the completion flag? Because I can still see that change. |
@makaveli10 Done :) |
This pull request includes several changes to the
whisper_live/client.py
file, focusing on improving the WebSocket connection handling, segment processing, and transcript writing. The most important changes are summarized below:WebSocket Connection Handling:
whisper_live/client.py
, whisper_live/client.pyR73-R75)User-Agent
header in the WebSocket connection. (whisper_live/client.py
, whisper_live/client.pyR85)Segment Processing:
process_segments
method by removing the check for thecompleted
flag. (whisper_live/client.py
, whisper_live/client.pyL115-R121)Transcript Writing:
write_srt_file
method to always append thelast_segment
to the transcript if it exists, regardless of its content. (whisper_live/client.py
, whisper_live/client.pyL262-R264)Code Cleanup:
max_clients
andmax_connection_time
from theon_open
method and the__init__
method of theClient
class. (whisper_live/client.py
, [1] [2]