Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument to set .cargo/config.toml path #14

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xbroquer
Copy link

By default, the configuration is stored at the ' 'colcon workspace' top level directory.
We faced an issue when the source code is in another location and when we use a symbolink link. In this case the config.toml generated in the colcon_ws is not found.

This option permits to set a custom place for the generated config.toml

@kmn4tor
Copy link

kmn4tor commented Jul 31, 2024

@esteve esteve self-requested a review August 29, 2024 09:32
Copy link
Member

@luca-della-vedova luca-della-vedova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not opposed to this feature, there will probably be some bikeshedding on the argument name (imho config path sounds a bit too generic) and comments / grammar, but to start with can you get the CI to be green? Most of them are flake8 issues but there are some actual test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants