#3156 = add some tests

coiouhkc · Jun 9, 2023 · ce62e60 · ce62e60
1 parent f23f730
commit ce62e60
Showing 1 changed file with 59 additions and 1 deletion.
diff --git a/rewrite-java/src/test/java/org/openrewrite/java/LombokUtilityClassTest.java b/rewrite-java/src/test/java/org/openrewrite/java/LombokUtilityClassTest.java
@@ -27,7 +27,7 @@ public static int add(final int x, final int y) {
                                 """,
                         """
                                 import lombok.experimental.UtilityClass;
-                                
+                                                                
                                 @UtilityClass
                                 public class A {
                                    public int add(final int x, final int y) {
@@ -39,6 +39,64 @@ public int add(final int x, final int y) {
         );
     }
 
+
+    @Test
+    void doNotUpgradeToUtilityClassIfNonStaticVariables() {
+        rewriteRun(
+                recipeSpec -> recipeSpec
+                        .recipes(
+                                new LombokUtilityClass()
+                        ),
+                java(
+                        """
+                                public class A {
+                                   private final int x = 0;
+                                   public static int add(final int x, final int y) {
+                                      return x + y;
+                                   }
+                                }
+                                """,
+                        """
+                                public class A {
+                                   private final int x = 0;
+                                   public static int add(final int x, final int y) {
+                                      return x + y;
+                                   }
+                                }
+                                """
+                )
+        );
+    }
+
+
+    @Test
+    void doNotUpgradeToUtilityClassIfNonStaticMethods() {
+        rewriteRun(
+                recipeSpec -> recipeSpec
+                        .recipes(
+                                addDependency("org.projectlombok:lombok:1.18.28", "false"),
+                                new LombokUtilityClass()
+                        ),
+                java(
+                        """
+                                public class A {
+                                   public int add(final int x, final int y) {
+                                      return x + y;
+                                   }
+                                }
+                                """,
+                        """
+                                public class A {
+                                   public int add(final int x, final int y) {
+                                      return x + y;
+                                   }
+                                }
+                                """
+                )
+        );
+    }
+
+
     private AddDependency addDependency(String gav, String onlyIfUsing) {
         return addDependency(gav, onlyIfUsing, null, null);
     }