feat: Use async faucet transactions and support wait/reload #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so that we use the transaction payload in the faucet transaction resource as the source of truth.
This makes it so that our faucet transactions will be created on the server-side without waiting for confirmation and then will be able to be waited-on / polled from the SDK. This allows us to have more stable faucet implementations (since there are fewer persistent connections across multiple services / clients) and will return a resource that can be more useful on the SDK side of things.
🟡 Heimdall Review Status
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This makes it so that our faucet transactions will be created on the server-side without waiting for confirmation and then will be able to be waited-on / polled from the SDK.
This allows us to have more stable faucet implementations (since there are fewer persistent connections across multiple services / clients) and will return a resource that can be more useful on the SDK side of things.
Qualified Impact
This makes it so that when you call
wallet.faucet()oraddress.faucet()it returns a faucet transaction that is not necessarily confirmed yet.