Implementing Unhydrated wallets and address.getTransfers (#28) #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdimaden
force-pushed
the
feat/psdk-178_unhydrated_wallets
branch
3 times, most recently
from
2172228 to
d24000f
Compare
erdimaden
force-pushed
the
feat/psdk-178_unhydrated_wallets
branch
from
d24000f to
549eb3a
Compare
erdimaden
changed the title
erdimaden
force-pushed
the
feat/psdk-178_unhydrated_wallets
branch
from
bd9ad92 to
f69bd85
Compare
erdimaden
force-pushed
the
feat/psdk-178_unhydrated_wallets
branch
from
0490bf4 to
2d00a53
Compare
erdimaden
commented
May 24, 2024
| @@ -134,8 +163,10 @@ export class Address { | |||
| intervalSeconds = 0.2, | |||
| timeoutSeconds = 10, | |||
| ): Promise<Transfer> { | |||
| if (!this.key) { | |||
There was a problem hiding this comment.
reference ruby implementation: https://github.com/coinbase/coinbase-sdk-ruby/blob/master/lib/coinbase/address.rb#L81
There was a problem hiding this comment.
Can we add a test for createTransfer when a key is not loaded that we throw an error?
There was a problem hiding this comment.
Yes, I have a test for createTransfer. I use an UnhydratedWallet to initiate a createTransfer request without a key on the Address Class. Does this approach work for you?
src/coinbase/tests/user_test.ts
Outdated
Comment on lines
260
to
265
| const baseWallet = HDKey.fromMasterSeed(bip39.mnemonicToSeedSync(seed)); | ||
| const wallet1 = baseWallet.derive("m/44'/60'/0'/0/0"); | ||
| const address1 = getAddressFromHDKey(wallet1); | ||
|
|
||
| const wallet2 = baseWallet.derive("m/44'/60'/0'/0/1"); | ||
| const address2 = getAddressFromHDKey(wallet2); |
There was a problem hiding this comment.
The deriveAddress function needs real wallets and addresses to operate.
erdimaden
force-pushed
the
feat/psdk-178_unhydrated_wallets
branch
5 times, most recently
from
7fce280 to
19f213d
Compare
Updating test cases
erdimaden
force-pushed
the
feat/psdk-178_unhydrated_wallets
branch
from
19f213d to
b87207c
Compare
erdimaden
changed the title
erdimaden
force-pushed
the
feat/psdk-178_unhydrated_wallets
branch
2 times, most recently
from
6c063d7 to
ebd3302
Compare
erdimaden
force-pushed
the
feat/psdk-178_unhydrated_wallets
branch
from
ebd3302 to
f7af680
Compare
erdimaden
force-pushed
the
feat/psdk-178_unhydrated_wallets
branch
from
db6929d to
0930583
Compare
erdimaden
force-pushed
the
feat/psdk-178_unhydrated_wallets
branch
from
603ca87 to
5c66c0b
Compare
alex-stone
approved these changes
May 24, 2024
erdimaden
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed and why?
We now support unhydrated Wallets, which handle read-only operations like checking balances and addresses. These wallets do not include a masterWallet unless initialized with a seed via the
setSeedmethod. The Address class has been updated to support this feature, similar to our Ruby SDK.Additionally:
deriveAddresstest case andaddressIndexissuesaddress.getTransfersmethod to return a list of transfersgenerateWalletFromSeedfunction to generate addresses and wallets from a given seedQualified Impact