Provide disableTimer option for testing #23
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Some consumers of cookie manager were reporting issues around introducing the package and seeing failed tests around timer usage. There are some documented alternatives like using
runOnlyPendingTimers
in place of functions likerunAllTimers
but this can quickly become cumbersome to maintain especially if there are multiple timing related functions that are being used and developers need to remember what workarounds are available for them to work well.Therefore, this PR introduces a
disableTimer
option on CookieProvider to avoid setting a timer for periodically checking cookies. This option is meant to be used in testing only.Notes to reviewers
How has it been tested?