Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-components): add CAD models style caching support #3603

Merged
merged 15 commits into from
Aug 21, 2023

Conversation

Savokr
Copy link
Contributor

@Savokr Savokr commented Aug 21, 2023

Type of change

Feat

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

Adds style caching support for CAD models. Also adds styling stress testing in CadModelContainer story.

How has this been tested? 🔍

  1. In HighlightNode story and in CadModelContainer story

Test instructions ℹ️

  1. Go to HighlightNode story and click on different mapped nodes
  2. Go to CadModelContainer story and click anywhere in the viewer a 10-20 times. You can see new styling groups appearing in the console.

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@Savokr Savokr requested a review from a team as a code owner August 21, 2023 11:56
@Savokr Savokr added auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack labels Aug 21, 2023
christjt
christjt previously approved these changes Aug 21, 2023
react-components/src/hooks/useCalculateModelsStyling.tsx Outdated Show resolved Hide resolved
@Savokr Savokr enabled auto-merge (squash) August 21, 2023 13:36
@Savokr Savokr merged commit 8e8554f into master Aug 21, 2023
13 checks passed
@Savokr Savokr deleted the savokr/model-styling-cache branch August 21, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants