-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-components): add pagination support for styling hook allowing styling more than 1000 nodes #3544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Savokr
added
auto-update
Makes bulldozer automatically update this PR when there are changes to the target branch
slack
PRs and issues with this label will be pushed to Slack
labels
Aug 2, 2023
christjt
requested changes
Aug 2, 2023
react-components/src/hooks/useMappedEquipmentBy3DModelsList.tsx
Outdated
Show resolved
Hide resolved
…ata/reveal into savokr/fix-styling-hook
…ata/reveal into savokr/fix-styling-hook
christjt
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-update
Makes bulldozer automatically update this PR when there are changes to the target branch
slack
PRs and issues with this label will be pushed to Slack
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/REV-972
Description 📝
This PR fixes an issue with styling hook where it was not styling more than 1000 nodes by externalId because of lacking pagination support in mapping fetching hook.
How has this been tested? 🔍
In ModelsStyling example from storybook.
Test instructions ℹ️
3dtest
projectChecklist ☑️