Skip to content

Commit

Permalink
feat: Make it possible to change the position of a datamodels backed …
Browse files Browse the repository at this point in the history
…360 collection (#4172)

* Change signature of add360ImageOptions for datamodels to include AddImage360Options

* Change public API signature
  • Loading branch information
anders-hopland authored Feb 8, 2024
1 parent d744ec9 commit 3932572
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion viewer/packages/api/src/public/migration/Cognite3DViewer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -844,7 +844,8 @@ export class Cognite3DViewer {
*/
async add360ImageSet(
datasource: 'datamodels',
dataModelIdentifier: Image360DataModelIdentifier
dataModelIdentifier: Image360DataModelIdentifier,
add360ImageOptions?: AddImage360Options
): Promise<Image360Collection>;
/**
* Adds a set of 360 images to the scene from the /events API in Cognite Data Fusion.
Expand Down
2 changes: 1 addition & 1 deletion viewer/reveal.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ export class ClusteredAreaCollection implements AreaCollection {
// @public (undocumented)
export class Cognite3DViewer {
constructor(options: Cognite3DViewerOptions);
add360ImageSet(datasource: 'datamodels', dataModelIdentifier: Image360DataModelIdentifier): Promise<Image360Collection>;
add360ImageSet(datasource: 'datamodels', dataModelIdentifier: Image360DataModelIdentifier, add360ImageOptions?: AddImage360Options): Promise<Image360Collection>;
add360ImageSet(datasource: 'events', eventFilter: {
[key: string]: string;
}, add360ImageOptions?: AddImage360Options): Promise<Image360Collection>;
Expand Down

0 comments on commit 3932572

Please sign in to comment.