Alternate way of fetching resources #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderland
reviewed
Dec 11, 2020
| labels=LabelFilter(contains_all=[label]), | ||
| limit=None, | ||
| assets = self._cognite_client.power_assets.list( | ||
| grid_type=grid_type, base_voltage=base_voltage, **{"metadata": {"type": power_type}} |
There was a problem hiding this comment.
**{"x":"y"} is commonly also known as x="y"
There was a problem hiding this comment.
Note power_type may be None
sanderland
reviewed
Dec 11, 2020
| labels=LabelFilter(contains_all=[label]), | ||
| limit=None, | ||
| ) | ||
| assets = [a for a in assets if a.external_id in [r.target_external_id for r in rels]] |
There was a problem hiding this comment.
target_external_ids = {r.target_external_id for r in rels}
and then in (set) here please
sanderland
reviewed
Dec 11, 2020
| labels=LabelFilter(contains_all=[label]), | ||
| limit=None, | ||
| ) | ||
| assets = [a for a in assets if a.external_id in [r.source_external_id for r in rels]] |
sanderland
suggested changes
Nov 15, 2022
| @@ -1,5 +1,4 @@ | |||
| import sys | |||
There was a problem hiding this comment.
Suggested change
| import sys | |
| import grouphug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with this pr it takes 2-3 secs to run client.substations.list().shunt_compensators(), but 1 minute to run client.substations.list().busbar_sections()