Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate: resync v0 #432

Merged
merged 11 commits into from
Oct 17, 2024
Merged

deprecate: resync v0 #432

merged 11 commits into from
Oct 17, 2024

Conversation

nodegard
Copy link
Contributor

@nodegard nodegard commented Oct 16, 2024

Description

  • Removed resync asset/v0 based
  • Removed support for 3.9 since dependencies required it

Checklist:

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 9 lines in your changes missing coverage. Please review.

Project coverage is 42.92%. Comparing base (b88621a) to head (3ec7daf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cognite/powerops/resync/utils.py 20.00% 4 Missing ⚠️
cognite/powerops/cli.py 33.33% 2 Missing ⚠️
cognite/powerops/resync/config_to_fdm.py 50.00% 2 Missing ⚠️
cognite/powerops/utils/helpers.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
- Coverage   49.68%   42.92%   -6.77%     
==========================================
  Files         569      497      -72     
  Lines       41160    36747    -4413     
==========================================
- Hits        20449    15772    -4677     
- Misses      20711    20975     +264     
Files with missing lines Coverage Δ
cognite/powerops/_version.py 100.00% <100.00%> (ø)
.../powerops/client/shop/data_classes/shop_results.py 40.44% <100.00%> (+0.67%) ⬆️
cognite/powerops/client/shop/shop_run_api.py 37.50% <100.00%> (-1.98%) ⬇️
...powerops/prerun_transformations/transformations.py 91.72% <100.00%> (-3.39%) ⬇️
cognite/powerops/resync/__init__.py 100.00% <100.00%> (ø)
cognite/powerops/resync/data_classes.py 33.33% <100.00%> (ø)
cognite/powerops/resync/main.py 34.61% <100.00%> (ø)
cognite/powerops/utils/cdf/extraction_pipelines.py 88.40% <100.00%> (ø)
tests/test_unit/test_resync/conftest.py 66.66% <ø> (-27.46%) ⬇️
tests/test_unit/test_resync/test_resync.py 81.81% <ø> (ø)
... and 5 more

... and 212 files with indirect coverage changes

Copy link
Contributor

@katrilh katrilh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be good to get rid of all this legacy 🚀
Just the dates needs a reformatting

CHANGELOG.md Outdated Show resolved Hide resolved
katrilh
katrilh previously approved these changes Oct 16, 2024
Co-authored-by: katrilh <[email protected]>
@nodegard nodegard merged commit dddb7a3 into main Oct 17, 2024
7 of 8 checks passed
@nodegard nodegard deleted the feat/remove-toolkit-dep branch October 17, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants