Diff production model #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
July 25, 2023 15:55
katrilh
commented
Aug 4, 2023
Comment on lines
+33
to
+43
| # @classmethod | ||
| # # i teorien, løftes til AssetType... kanskje | ||
| # def from_cdf( | ||
| # cls, | ||
| # client, | ||
| # external_id: str, | ||
| # fetch_relationships: bool = False, | ||
| # fetch_content: bool = False, | ||
| # ) -> DayAheadProcess: | ||
| # raise NotImplementedError() | ||
|
|
There was a problem hiding this comment.
The idea behind keeping this (for now) is to be able to check the same functionality on the market models , so far the only testing has been on production models
|
Great work! Readable and easy to follow 😄 Seems like this resolved the weird diff we were getting with resync plan as well |
Juliamg
approved these changes
Aug 7, 2023
haukb
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe the change you have made.
Checklist: