Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify make connection #754

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Simplify make connection #754

merged 2 commits into from
Nov 16, 2024

Conversation

nikokaoja
Copy link
Collaborator

Before:

source = (URIRef("http://purl.org/cognite/neat/Activity"),
          URIRef("http://purl.org/cognite/neat/workorderItemname"))

connection = "asset"

target = (URIRef("http://purl.org/cognite/neat/Asset"),
          URIRef("http://purl.org/cognite/neat/wmtTagName"))

Now:

source = ("Activity","workorderItemname")

connection = "asset"

target = ("Asset","wmtTagName")

@nikokaoja nikokaoja requested a review from a team as a code owner November 16, 2024 08:36
@github-actions GitHub Actions
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
14997 10048 67% 60% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite/neat/_graph/queries/_base.py 67% 🟢
cognite/neat/_session/_prepare.py 41% 🟢
TOTAL 54% 🟢

updated for commit: 61caf7f by action🐍

doctrino
doctrino reviewed Nov 16, 2024
View reviewed changes
cognite/neat/_graph/queries/_base.py
@@ -42,6 +42,27 @@ def summarize_instances(self) -> list[tuple]:
for res in list(self.graph.query(query_statement))
]

@property
def types(self) -> dict[URIRef, str]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@nikokaoja nikokaoja merged commit 9e6111c into main Nov 16, 2024
7 checks passed
@nikokaoja nikokaoja deleted the simplify-make-connection branch November 16, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doctrino doctrino doctrino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikokaoja @doctrino