-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neat session rules provenance #712
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very good work, very powerful concept to add to the code base.
There seems to be some inconsistencies with type. Should entity ids be string or URIRef. In addition, in the provenance method I see what I would consider invalid triples with tuple[URIRef, URIRef, str | None]
. Is this intentional?
We have following:
Source Entity
which is used byActivity
executed byAgent
to generateTarget Entity
.