Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neat session rules provenance #712

Merged
merged 28 commits into from
Nov 11, 2024
Merged

Neat session rules provenance #712

merged 28 commits into from
Nov 11, 2024

Conversation

nikokaoja
Copy link
Collaborator

@nikokaoja nikokaoja commented Nov 5, 2024

image

We have following:

Source Entity which is used by Activity executed by Agent to generate Target Entity.

  • Source Entity : Excel file, OWL, InputRules, ValidatedRules
  • Agents: Rules transformers (e.g., verify, converters, reducers, etc.)
  • Activity: conversion, verification, ...
  • Target Entity: InputRules, ValidatedRules

Copy link

github-actions bot commented Nov 5, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
14438 9746 68% 60% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite/neat/_constants.py 92% 🟢
cognite/neat/_graph/extractors/_base.py 82% 🟢
cognite/neat/_graph/extractors/_classic_cdf/_assets.py 96% 🟢
cognite/neat/_graph/extractors/_classic_cdf/_base.py 87% 🟢
cognite/neat/_graph/extractors/_classic_cdf/_classic.py 36% 🟢
cognite/neat/_graph/extractors/_classic_cdf/_data_sets.py 91% 🟢
cognite/neat/_graph/extractors/_classic_cdf/_events.py 96% 🟢
cognite/neat/_graph/extractors/_classic_cdf/_files.py 85% 🟢
cognite/neat/_graph/extractors/_classic_cdf/_labels.py 90% 🟢
cognite/neat/_graph/extractors/_classic_cdf/_relationships.py 95% 🟢
cognite/neat/_graph/extractors/_classic_cdf/_sequences.py 95% 🟢
cognite/neat/_graph/extractors/_classic_cdf/_timeseries.py 87% 🟢
cognite/neat/_graph/extractors/_dexpi.py 89% 🟢
cognite/neat/_graph/extractors/_dms.py 66% 🟢
cognite/neat/_graph/extractors/_iodd.py 70% 🟢
cognite/neat/_graph/extractors/_mock_graph_generator.py 20% 🟢
cognite/neat/_graph/extractors/_rdf_file.py 87% 🟢
cognite/neat/_graph/loaders/_rdf2dms.py 76% 🟢
cognite/neat/_graph/queries/_base.py 69% 🟢
cognite/neat/_rules/importers/init.py 79% 🟢
cognite/neat/_rules/importers/_base.py 88% 🟢
cognite/neat/_rules/importers/_dms2rules.py 77% 🟢
cognite/neat/_rules/models/asset/_rules.py 89% 🟢
cognite/neat/_rules/models/asset/_rules_input.py 93% 🟢
cognite/neat/_rules/models/dms/_rules.py 91% 🟢
cognite/neat/_rules/models/dms/_rules_input.py 96% 🟢
cognite/neat/_rules/models/domain.py 96% 🟢
cognite/neat/_rules/models/information/_rules.py 88% 🟢
cognite/neat/_rules/models/information/_rules_input.py 96% 🟢
cognite/neat/_rules/transformers/_base.py 89% 🟢
cognite/neat/_rules/transformers/_converters.py 67% 🟢
cognite/neat/_session/_base.py 66% 🟢
cognite/neat/_session/_inspect.py 38% 🟢
cognite/neat/_session/_prepare.py 43% 🟢
cognite/neat/_session/_read.py 67% 🟢
cognite/neat/_session/_set.py 52% 🟢
cognite/neat/_session/_show.py 36% 🟢
cognite/neat/_session/_state.py 74% 🟢
cognite/neat/_session/_to.py 63% 🟢
cognite/neat/_shared.py 77% 🟢
cognite/neat/_store/_base.py 73% 🟢
cognite/neat/_store/_provenance.py 77% 🟢
TOTAL 77% 🟢

updated for commit: 80e4a7e by action🐍

Copy link
Collaborator

@doctrino doctrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very good work, very powerful concept to add to the code base.

There seems to be some inconsistencies with type. Should entity ids be string or URIRef. In addition, in the provenance method I see what I would consider invalid triples with tuple[URIRef, URIRef, str | None]. Is this intentional?

@nikokaoja nikokaoja merged commit ab6ea5b into main Nov 11, 2024
7 checks passed
@nikokaoja nikokaoja deleted the neat-session-rules-provenance branch November 11, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants